Remove duplicate 'mock_supervisor_comms' pytest fixture definitions#49457
Merged
amoghrajesh merged 11 commits intoapache:mainfrom Apr 22, 2025
Merged
Remove duplicate 'mock_supervisor_comms' pytest fixture definitions#49457amoghrajesh merged 11 commits intoapache:mainfrom
amoghrajesh merged 11 commits intoapache:mainfrom
Conversation
amoghrajesh
reviewed
Apr 21, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
We have a couple more occurrences of this, in:
airflow-core/tests/conftest.pyproviders/openlineage/tests/unit/openlineage/plugins/test_listener.py(create a seperate PR for this please)
amoghrajesh
reviewed
Apr 21, 2025
Contributor
Author
|
@amoghrajesh These are the locations where
I had initially retained it in 1, so it can be removed from 2 and 3. |
Contributor
If we have it in the pytest_plugin.py, it means it can be accessed from anywhere in the codebase. So you should be able to remove every other occurence. For the providers, make a different PR, rest can be in this one |
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
Backport successfully created: v3-0-test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the
mock_supervisor_commspytest fixure from -airflow-core/tests/unit/hooks/test_base.py
airflow-core/tests/unit/models/test_taskinstance.py
airflow-core/tests/conftest.py
as it is already defined in devel-common/src/tests_common/pytest_plugin.py
Created #49520 to delete the definition from providers/openlineage/tests/unit/openlineage/plugins/test_listener.py