Bring back serve_logs to be in the core#49031
Merged
Merged
Conversation
potiuk
requested review from
dstandish,
hussein-awala and
vincbeck
as code owners
April 10, 2025 04:16
potiuk
commented
Apr 10, 2025
potiuk
force-pushed
the
bring-back-serve-log-to-core
branch
2 times, most recently
from
April 10, 2025 04:22
e6cc4dd to
50fa3f2
Compare
ashb
approved these changes
Apr 10, 2025
Contributor
|
A small static check failure: |
amoghrajesh
approved these changes
Apr 10, 2025
kaxil
approved these changes
Apr 10, 2025
The `serve_logs` has been moved in apache#48457 to fab provider by mistake. It should remain in the airflow-core. We still depend on flask in the core (but as a next step we can replace it by starlette and unicorn). Fixes: apache#49028
kaxil
force-pushed
the
bring-back-serve-log-to-core
branch
from
April 10, 2025 08:23
50fa3f2 to
c61caf6
Compare
eladkal
reviewed
Apr 10, 2025
eladkal
approved these changes
Apr 10, 2025
Member
Author
|
Thanks @kaxil for the fixup :D |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
serve_logshas been moved in #48457 to fab provider by mistake. It should remain in the airflow-core. We still depend on flask in the core (but as a next step we can replace it by starlette and unicorn).Fixes: #49028
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.