Add back methods needed by Flask in AirflowAppBuilder#48968
Merged
Conversation
vincbeck
force-pushed
the
vincbeck/fab_url_login
branch
from
April 8, 2025 18:39
609080a to
80e1aed
Compare
get_url_for_login in AirflowAppBuilderAirflowAppBuilder
vincbeck
force-pushed
the
vincbeck/fab_url_login
branch
2 times, most recently
from
April 8, 2025 19:04
9ab6a22 to
a0cb8ec
Compare
eladkal
reviewed
Apr 9, 2025
potiuk
approved these changes
Apr 9, 2025
Member
|
With nit from Elad |
vincbeck
force-pushed
the
vincbeck/fab_url_login
branch
from
April 9, 2025 13:47
a0cb8ec to
cd12350
Compare
o-nikolas
approved these changes
Apr 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in Slack.
Some methods are not used in Airflow codebase but by Flask itself. We need to add them back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.