Skip to content

Remove sqlite provider from preinstalled and use aiosqlite as core dep#48966

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:move-aiosqlite-to-be-core-dependency
Apr 9, 2025
Merged

Remove sqlite provider from preinstalled and use aiosqlite as core dep#48966
potiuk merged 1 commit into
apache:mainfrom
potiuk:move-aiosqlite-to-be-core-dependency

Conversation

@potiuk

@potiuk potiuk commented Apr 8, 2025

Copy link
Copy Markdown
Member

Aiosqlite has never been used by the sqlite provider it is really needed as async extension in case Airflow would be configured with async engine. So if we are removing sqlite provider as preinstalled, we should move aiosqlite as required depdendency of core as otherwise creating async sqlite engine will fail.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
potiuk requested review from dstandish and kaxil April 8, 2025 18:10
@potiuk
potiuk force-pushed the move-aiosqlite-to-be-core-dependency branch from 6d1245c to fea7a8c Compare April 8, 2025 18:16

@ashb ashb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me -- aiosqlite is a tiny pure-python dep too

@potiuk
potiuk force-pushed the move-aiosqlite-to-be-core-dependency branch from fea7a8c to 159b7d6 Compare April 8, 2025 20:26
@potiuk

potiuk commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

OK. I had to also importorskip the test_connection tests based on presence of the SQLite Provider - because that's what lower-dep test does now - it removes the sqlite provider because it is not required dependency.

@potiuk

potiuk commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

That's probably not the best way of handling it - idealy we should move those failing tests to provider, but I think it's good for now.

@potiuk
potiuk force-pushed the move-aiosqlite-to-be-core-dependency branch 4 times, most recently from 31135e6 to 1a48ba9 Compare April 9, 2025 01:21
Aiosqlite has never been used by the sqlite provider it is really
needed as async extension in case Airflow would be configured
with async engine. So if we are removing sqlite provider as
preinstalled, we should move aiosqlite as required depdendency of
core as otherwise creating async sqlite engine will fail.
@potiuk
potiuk force-pushed the move-aiosqlite-to-be-core-dependency branch from 1a48ba9 to 37c8b50 Compare April 9, 2025 02:25
@potiuk
potiuk requested a review from gopidesupavan as a code owner April 9, 2025 02:25
@potiuk

potiuk commented Apr 9, 2025

Copy link
Copy Markdown
Member Author

Merging it. There is a new problem exposed by failing docker build test but this one is related to old setuptools version and new wheel - I will solve it separately.

@potiuk
potiuk merged commit 45cb7f1 into apache:main Apr 9, 2025
@potiuk
potiuk deleted the move-aiosqlite-to-be-core-dependency branch April 9, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants