Move ObjectStoragePath and attach to Task SDK#48906
Merged
Merged
Conversation
uranusjr
force-pushed
the
sdk-objectstoragepath
branch
3 times, most recently
from
April 8, 2025 04:16
0bc259e to
3a4eb75
Compare
uranusjr
marked this pull request as ready for review
April 8, 2025 04:55
uranusjr
requested review from
amoghrajesh,
ashb,
bolkedebruin,
kaxil and
mobuchowski
as code owners
April 8, 2025 04:55
kaxil
reviewed
Apr 8, 2025
kaxil
reviewed
Apr 8, 2025
amoghrajesh
reviewed
Apr 9, 2025
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good, only thing is that I think we need to move the tests from airflow-core/tests/unit/io to sdk too.
These things don't actually work without Core, which should be available at runtime. But you can import the class and function and call them at the top-level.
uranusjr
force-pushed
the
sdk-objectstoragepath
branch
2 times, most recently
from
April 9, 2025 09:01
bcad6b2 to
d6a3301
Compare
uranusjr
force-pushed
the
sdk-objectstoragepath
branch
from
April 9, 2025 09:18
d6a3301 to
bb5f696
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These things don't actually work without Core, which should be available at runtime. But you can import the class and function and call them at the top-level.
Close #45425.