Implement on_execute_callback in task sdk#47989
Merged
Merged
Conversation
uranusjr
force-pushed
the
task-sdk-on-execute-callback
branch
from
March 20, 2025 09:46
5c44871 to
fca51b4
Compare
kaxil
reviewed
Mar 20, 2025
kaxil
reviewed
Mar 20, 2025
kaxil
approved these changes
Mar 20, 2025
The callable is run *outside* of the timeout block. Failures calling any callback functions are simply logged without failing the entire task. This matches Airflow 2's behavior. Submitting this first to get feedback. Other callbacks will be implemented in later PRs if I'm on the right track.
uranusjr
force-pushed
the
task-sdk-on-execute-callback
branch
from
March 20, 2025 10:23
fca51b4 to
b6d5536
Compare
7 tasks
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
The callable is run *outside* of the timeout block. Failures calling any callback functions are simply logged without failing the entire task. This matches Airflow 2's behavior. Submitting this first to get feedback. Other callbacks will be implemented in later PRs if I'm on the right track.
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Mar 22, 2025
The callable is run *outside* of the timeout block. Failures calling any callback functions are simply logged without failing the entire task. This matches Airflow 2's behavior. Submitting this first to get feedback. Other callbacks will be implemented in later PRs if I'm on the right track.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
The callable is run *outside* of the timeout block. Failures calling any callback functions are simply logged without failing the entire task. This matches Airflow 2's behavior. Submitting this first to get feedback. Other callbacks will be implemented in later PRs if I'm on the right track.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callable is run outside of the timeout block. Failures calling any callback functions are simply logged without failing the entire task. This matches Airflow 2's behavior.
Submitting this first to get feedback. Other callbacks will be implemented in later PRs if I'm on the right track.
First part of #45424.