Fix get_hook() got an unexpected keyword argument 'hook_params' in SQLExecuteQueryTrigger#47728
Merged
eladkal merged 4 commits intoMar 13, 2025
Merged
Conversation
…ovider has still to be Airflow 2.9 compatible, so introduced a get_hook method which gets the connection first for given conn_id and the gets the hook with given hook_params on that returned connection as the shortcut method doesn't exist yet in Airflow 2.9
67 tasks
potiuk
approved these changes
Mar 13, 2025
eladkal
approved these changes
Mar 13, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…LExecuteQueryTrigger (apache#47728) * refactor: Refactored the way how to get the hook as the common sql provider has still to be Airflow 2.9 compatible, so introduced a get_hook method which gets the connection first for given conn_id and the gets the hook with given hook_params on that returned connection as the shortcut method doesn't exist yet in Airflow 2.9 * refactor: Re-organized imports of TestSQLExecuteQueryTrigger --------- Co-authored-by: David Blain <david.blain@infrabel.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the way how to get the hook as the common sql provider has still to be Airflow 2.9 compatible, so introduced a get_hook method in SQLExecuteQueryTrigger which gets the connection first for given conn_id and then gets the hook with given hook_params on that returned connection as the shortcut method doesn't exist yet in Airflow 2.9
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.