Skip to content

Use structlog for GitDagBundle#47685

Merged
dstandish merged 3 commits into
apache:mainfrom
astronomer:switch-back-to-structlog-from-log_debug-helper
Mar 14, 2025
Merged

Use structlog for GitDagBundle#47685
dstandish merged 3 commits into
apache:mainfrom
astronomer:switch-back-to-structlog-from-log_debug-helper

Conversation

@dstandish

@dstandish dstandish commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature. I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper. We can remove it now that structlog is expected to be in 3.0.

Also, remove logging mixin and just use structlog.

@dstandish dstandish changed the title Replace log_debug helper with structlog Use structlog for GitDagBundle Mar 12, 2025
Comment thread airflow/dag_processing/bundles/git.py
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature.  I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper.  We can remove it now that structlog is expected to be in 3.0.
@dstandish
dstandish force-pushed the switch-back-to-structlog-from-log_debug-helper branch from 24ab3e9 to 6f5e39b Compare March 12, 2025 19:22
@dstandish
dstandish merged commit cd1340b into apache:main Mar 14, 2025
@dstandish
dstandish deleted the switch-back-to-structlog-from-log_debug-helper branch March 14, 2025 03:10
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature.  I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper.  We can remove it now that structlog is expected to be in 3.0.
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature.  I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper.  We can remove it now that structlog is expected to be in 3.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants