Skip to content

FAB login. Fix asset URLs and missing alert#47586

Merged
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/fab_webpack
Mar 11, 2025
Merged

FAB login. Fix asset URLs and missing alert#47586
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/fab_webpack

Conversation

@vincbeck

Copy link
Copy Markdown
Contributor

Resolves #47565


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Comment thread providers/fab/src/airflow/providers/fab/www/package.json
@vincbeck
vincbeck requested review from ashb and pierrejeambrun March 10, 2025 20:58
@vincbeck
vincbeck force-pushed the vincbeck/fab_webpack branch from e7a1f03 to 3dc8d11 Compare March 10, 2025 21:02
@vincbeck

Copy link
Copy Markdown
Contributor Author

This resolves all front-end errors on the login page except one:

Uncaught TypeError: moment(...).tz(...).format is not a function
    at r (main.ec1d38d994d72bb083cd.js:2:826)
    at u (main.ec1d38d994d72bb083cd.js:2:2623)
    at HTMLDocument.<anonymous> (main.ec1d38d994d72bb083cd.js:2:4808)
    at e (jquery-latest.js:2:30038)
    at jquery-latest.js:2:30340

Looking into it but that can fixed in a separate PR

@vincbeck
vincbeck force-pushed the vincbeck/fab_webpack branch from 3dc8d11 to 7bac225 Compare March 10, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAB auth manager doesn't show error messages on failed log in

4 participants