Use a single http tag to report the server's location to front end, not two#47572
Merged
Conversation
ashb
requested review from
bbovenzi,
eladkal,
ephraimbuddy,
jscheffl,
o-nikolas,
pierrejeambrun and
ryanahamilton
as code owners
March 10, 2025 14:56
bbovenzi
approved these changes
Mar 10, 2025
Member
|
Let me just try this locally, one moment please :) |
Member
Author
|
@pierrejeambrun Please. It seemed to work find for me in dev and prod modes |
Member
Member
|
Well, I just tried on main and things do not seem to work anymore either..... :( but the errors are different |
pierrejeambrun
approved these changes
Mar 10, 2025
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Nice thanks.
Maybe later we will still want two settings in case the static file are hosted somewhere else (cdn) but for now that's much cleaner.
ashb
force-pushed
the
single-base-url-for-ui
branch
3 times, most recently
from
March 11, 2025 11:21
3d83702 to
7dcc872
Compare
…ot two
Previously we had both a `<base href="">` tag and a `<meta
name="backend-server-base-url" content="">` tag that contained almost the same
value -- one had a trailing `/` and the other didn't.
That irked me, so I updated things so the XHR requests take the URL based on
the `<base>` tag instead.
In order to make this change I made the following changes:
- Instead of erroring if the URL does have a trailing `/`, the behaviour is
now to add it if it's missing. This makes it easier kn users
- This necessitated updating the Auth Managers to use a proper URL function,
not string concatenation, to build the URLs
The change to `conf.set` is a side-effect/fix to allow `conf.set("api",
"base_url")` to work -- otherwise it errored with "No section found" with only
the defaults present
ashb
force-pushed
the
single-base-url-for-ui
branch
from
March 11, 2025 13:42
7dcc872 to
89caf69
Compare
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…ot two (apache#47572) Previously we had both a `<base href="">` tag and a `<meta name="backend-server-base-url" content="">` tag that contained almost the same value -- one had a trailing `/` and the other didn't. That irked me, so I updated things so the XHR requests take the URL based on the `<base>` tag instead. In order to make this change I made the following changes: - Instead of erroring if the URL does have a trailing `/`, the behaviour is now to add it if it's missing. This makes it easier kn users - This necessitated updating the Auth Managers to use a proper URL function, not string concatenation, to build the URLs The change to `conf.set` is a side-effect/fix to allow `conf.set("api", "base_url")` to work -- otherwise it errored with "No section found" with only the defaults present.
This was referenced Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously we had both a
<base href="">tag and a<meta name="backend-server-base-url" content="">tag that contained almost the samevalue -- one had a trailing
/and the other didn't.That irked me, so I updated things so the XHR requests take the URL based on
the
<base>tag instead.In order to make this change I made the following changes:
/, the behaviour isnow to add it if it's missing. This makes it easier kn users
not string concatenation, to build the URLs
The change to
conf.setis a side-effect/fix to allowconf.set("api", "base_url")to work -- otherwise it errored with "No section found" with onlythe defaults present
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.