AIP-84 | Add Auth for Config#47208
Merged
Merged
Conversation
jason810496
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
February 28, 2025 12:28
47 tasks
pierrejeambrun
approved these changes
Mar 3, 2025
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Nice, one nit that should be good to figure out. Basically the permission decorator should not change the openapi spec. (beside the auth scheme)
jason810496
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 3, 2025 13:01
c9bbbef to
87f0452
Compare
jason810496
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 3, 2025 14:28
87f0452 to
b18f228
Compare
jason810496
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 4, 2025 11:58
b18f228 to
77e94c0
Compare
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Need rebase to solve conflicts.
jason810496
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 4, 2025 13:02
77e94c0 to
94e326c
Compare
Member
|
The CI error persists. That's weird |
Member
|
it's not the config that is problematic now: |
Member
Author
Thanks to point it out, let me take a look at python client test and fix it. |
jason810496
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 5, 2025 14:55
94e326c to
87736b5
Compare
jason810496
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 6, 2025 13:32
87736b5 to
df667fb
Compare
Member
|
I have a fix for Tests / CI image checks / Test Python API client (pull_request) basically that is not specifically related to this PR. The test is just broken at the moment. (passing on main but not testing anything) |
Member
Lee-W
force-pushed
the
feature/AIP-84/auth/config
branch
from
March 7, 2025 07:56
df667fb to
12bdc65
Compare
Lee-W
approved these changes
Mar 7, 2025
Member
|
As this has been approved and full test passed, I'm merging this one |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* AIP-84 | Add Auth for Config * Fix requires_access_configuration schema * Refactor requires_access_configuration with lambda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #42360
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.