Add legacy namespace packages to airflow.providers#47064
Merged
potiuk merged 1 commit intoFeb 25, 2025
Conversation
potiuk
requested review from
Fokko,
ashb,
bolkedebruin,
eladkal,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
mik-laj,
mobuchowski and
o-nikolas
as code owners
February 25, 2025 14:50
Lee-W
self-requested a review
February 25, 2025 14:52
Member
Author
|
Generated contents of the .whl distributions: Both |
potiuk
force-pushed
the
add-legacy-namespace-package-to-providers
branch
3 times, most recently
from
February 25, 2025 15:50
723fb82 to
bdcae41
Compare
aritra24
approved these changes
Feb 25, 2025
potiuk
force-pushed
the
add-legacy-namespace-package-to-providers
branch
2 times, most recently
from
February 25, 2025 19:40
b901d04 to
cf1beb4
Compare
jscheffl
approved these changes
Feb 25, 2025
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Aaaah, cool. Finally after re-structuring the syntax highlighting in VSCode works again!
Member
Author
Indeed looks like :) |
It seem that vscode cannot recognise cross-provider imports when providers have implicit namespaces for "airflow.providers" and "airflow.providers.nnnn" (for "common" etc.). And what seem to halp is to add legacy namespace `__init__.py` files for those packages. This has no impact on generated packages - because generated packages have "tool.flit.module" set to the right sub-package and flit will not use the __init__.py files when packages are generated.
potiuk
force-pushed
the
add-legacy-namespace-package-to-providers
branch
from
February 25, 2025 20:21
cf1beb4 to
a847bc5
Compare
Member
Author
|
Random failure. Merging :) |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
It seem that vscode cannot recognise cross-provider imports when providers have implicit namespaces for "airflow.providers" and "airflow.providers.nnnn" (for "common" etc.). And what seem to halp is to add legacy namespace `__init__.py` files for those packages. This has no impact on generated packages - because generated packages have "tool.flit.module" set to the right sub-package and flit will not use the __init__.py files when packages are generated.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
It seem that vscode cannot recognise cross-provider imports when providers have implicit namespaces for "airflow.providers" and "airflow.providers.nnnn" (for "common" etc.). And what seem to halp is to add legacy namespace `__init__.py` files for those packages. This has no impact on generated packages - because generated packages have "tool.flit.module" set to the right sub-package and flit will not use the __init__.py files when packages are generated.
This was referenced Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seem that vscode cannot recognise cross-provider imports when providers have implicit namespaces for "airflow.providers" and "airflow.providers.nnnn" (for "common" etc.). And what seem to halp is to add legacy namespace
__init__.pyfiles for those packages.This has no impact on generated packages - because generated packages have "tool.flit.module" set to the right sub-package and flit will not use the init.py files when packages are generated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.