Validation logic for the payload moved to the Serializer for trigger_dag_run#46882
Merged
Conversation
sunank200
force-pushed
the
non-public-run-after
branch
from
February 19, 2025 06:41
e512813 to
208a98a
Compare
sunank200
marked this pull request as ready for review
February 19, 2025 07:00
Lee-W
approved these changes
Feb 19, 2025
Lee-W
left a comment
Member
There was a problem hiding this comment.
Do we need to add a test case for validate_context?
Collaborator
Author
There is already a test for trigger_dag_run which calls |
sunank200
force-pushed
the
non-public-run-after
branch
from
February 19, 2025 15:57
32d2b80 to
546ad45
Compare
pierrejeambrun
approved these changes
Feb 19, 2025
uranusjr
reviewed
Feb 20, 2025
uranusjr
reviewed
Feb 20, 2025
uranusjr
reviewed
Feb 20, 2025
sunank200
force-pushed
the
non-public-run-after
branch
from
February 20, 2025 05:52
a3f6d7d to
1dfaa23
Compare
uranusjr
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the payload validation logic is moved to the Serializer. When the payload is loaded into a
TriggerDAGRunPostBodyobject, it should be valid as is without further validation/manipulation.This closes: 46650#issuecomment-2654340014
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.