Refactor Azure Service Bus: move create_subscription to hook#45125
Merged
shahar1 merged 2 commits intoapache:mainfrom Dec 21, 2024
perry2of5:move-asb-create-subscription-to-hook
Merged
Refactor Azure Service Bus: move create_subscription to hook#45125shahar1 merged 2 commits intoapache:mainfrom perry2of5:move-asb-create-subscription-to-hook
shahar1 merged 2 commits intoapache:mainfrom
perry2of5:move-asb-create-subscription-to-hook
Conversation
Contributor
Author
|
The build failure appears unrelated to my re-wording of the comment :) |
This commit refactors the logic to create a subscription into the hook. The operators should not be accessing the connection to Azure Service Bus directly. This code belongs in the hook to promote reuse.
Member
|
Yeah. Fixed in main (including #45131 fixing selective checks that caused broken main). Rebased it now. |
shahar1
approved these changes
Dec 21, 2024
Contributor
Author
|
Thank you to both of you!
|
Contributor
Nicely done, good work! |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…45125) * Move create_subscription to hook This commit refactors the logic to create a subscription into the hook. The operators should not be accessing the connection to Azure Service Bus directly. This code belongs in the hook to promote reuse. * Fix comment to match code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the logic to create a subscription into the hook. The operators should not be accessing the connection to Azure Service Bus directly. This code belongs in the hook to promote reuse.
In addition, it allows the caller to pass a RuleFilter to apply to the subscription to limit which messages are sent to the subscription.
@dabla: this addresses part of your comments on PR 44675