Merged
Conversation
Member
Author
|
I want to make this one pass - and then - separately - do refactoring with merging those changes in task instance. |
29509e8 to
5fd0e92
Compare
jscheffl
approved these changes
Dec 1, 2024
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
3 small santity check questions, else looks good in my view as a first pass cleaning.
providers/src/airflow/providers/amazon/aws/transfers/google_api_to_s3.py
Show resolved
Hide resolved
Contributor
|
I'm adding "full tests needed" as I think especially the task instance is a "danger zone" of side effects - same as we had with sensor base.py changes. |
5fd0e92 to
04a937f
Compare
potiuk
commented
Dec 1, 2024
04a937f to
6f706e6
Compare
17 tasks
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Part of apache#44436 Co-authored-by: kalyanr <kalyan.ben10@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #44436
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.