Skip to content

Remove AIP-44 from airflow/sensors/base.py (2nd Attempt)#44529

Merged
jscheffl merged 1 commit intoapache:mainfrom
jscheffl:feature/remove-internal-api-from-sensors-base-v2
Dec 1, 2024
Merged

Remove AIP-44 from airflow/sensors/base.py (2nd Attempt)#44529
jscheffl merged 1 commit intoapache:mainfrom
jscheffl:feature/remove-internal-api-from-sensors-base-v2

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl commented Dec 1, 2024

related: #44436

Second attempt of #44518, hoping to NOT hit mypy issues again in all providers. Implemented it as it was prior Internal API w/o touching the sensor interface.

  • ./airflow/sensors/base.py: _orig_start_date

@jscheffl jscheffl added the full tests needed We need to run full set of tests for this PR to merge label Dec 1, 2024
@jscheffl
Copy link
Copy Markdown
Contributor Author

jscheffl commented Dec 1, 2024

Okay, mypy checks again, I'll shortly wait until #44434 is merged, then these problems will be gone with a re-base

@jscheffl jscheffl force-pushed the feature/remove-internal-api-from-sensors-base-v2 branch from 198812d to d1668e9 Compare December 1, 2024 11:50
@jscheffl jscheffl merged commit 1ee37a0 into apache:main Dec 1, 2024
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@jscheffl jscheffl deleted the feature/remove-internal-api-from-sensors-base-v2 branch October 5, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants