Fixing rendering of code block for newsfragment command#44419
Merged
amoghrajesh merged 2 commits intoapache:mainfrom Nov 27, 2024
Merged
Fixing rendering of code block for newsfragment command#44419amoghrajesh merged 2 commits intoapache:mainfrom
amoghrajesh merged 2 commits intoapache:mainfrom
Conversation
kaxil
approved these changes
Nov 27, 2024
phanikumv
approved these changes
Nov 27, 2024
Lee-W
approved these changes
Nov 27, 2024
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 28, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/airflow/pull/44378/files introduced newsfragment templating 👏🏽
However, github wasnt able to render the command due to a missing line.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.