Merged
Conversation
2cb1ffb to
17a2204
Compare
7 tasks
ed021ea to
b73a393
Compare
b73a393 to
1d06260
Compare
Lee-W
approved these changes
Nov 27, 2024
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First one for #42317. The idea is pretty straightfoward.
Existing CLIs mostly use the Marshmallow models (from Connexion), but I opted to use the Pydantic models (for FastAPI) instead. I assume we’ll change those at some point anyway?
I also added the two fields added to Asset recently to the model. This would affect the endpoints, so we’ll see what happens…