Move OpenAPI tests to breeze container#44326
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
THat all looks very cool! Let's see if CI turns green... then then LGTM in my view!
8c479db to
4b7f4e8
Compare
|
Full tests not triggering , might be because of changes to workflows? @potiuk does this change need to come from the apache repo? |
|
|
ah it seems this one: 
|
This looks like github actions have hard limit. |
|
Alright one test failing but, its not related to this i believe. i will check that separate.. |
This is fixed after removing openapi tests workflow :) |
|
Added some comments - it looks fantastic in general, but I found a few places where things might be improved. We could also use the opportunity to rename those tests to be "python-api-client-tests" across the board. |
cool, thanks those really great improvement suggestions let me have a updates on those :) |
|
BTW. I really like how this
|
potiuk
left a comment
There was a problem hiding this comment.
Nice! Just the last two changes !
|
Cool! |
* move openapi tests to breeze container * remove space * move openapi tests inside special tests workflow * merge openapi tests into special tests workflow * use postgres backend for openapi tests * ignore tmp folder tests discovery in openapi tests * adding retries to python client tests connection * adding retries to python client tests connection * export auth backend configs * use connectivity check to verify webserver started or not * rename is-special-tests-require to special-tests-required * rename openapi-tests to python-api-client-tests * rename static-checks-mypy-docs.yml to ci-image-checks.yml * rename static-checks-mypy-docs.yml to ci-image-checks.yml * remove special-tests-required param
* move openapi tests to breeze container * remove space * move openapi tests inside special tests workflow * merge openapi tests into special tests workflow * use postgres backend for openapi tests * ignore tmp folder tests discovery in openapi tests * adding retries to python client tests connection * adding retries to python client tests connection * export auth backend configs * use connectivity check to verify webserver started or not * rename is-special-tests-require to special-tests-required * rename openapi-tests to python-api-client-tests * rename static-checks-mypy-docs.yml to ci-image-checks.yml * rename static-checks-mypy-docs.yml to ci-image-checks.yml * remove special-tests-required param
* move openapi tests to breeze container * remove space * move openapi tests inside special tests workflow * merge openapi tests into special tests workflow * use postgres backend for openapi tests * ignore tmp folder tests discovery in openapi tests * adding retries to python client tests connection * adding retries to python client tests connection * export auth backend configs * use connectivity check to verify webserver started or not * rename is-special-tests-require to special-tests-required * rename openapi-tests to python-api-client-tests * rename static-checks-mypy-docs.yml to ci-image-checks.yml * rename static-checks-mypy-docs.yml to ci-image-checks.yml * remove special-tests-required param
closes: #44020
Running Open API client tests directly in the runner environment is fragile due to the need for manual installation of Airflow and providers, which can cause dependency conflicts and installation errors. Breeze offers a consistent, containerized setup.
Moving openapi tests run inside breeze container. Breeze uses a pre-configured container image, avoiding the need for manual installation of Airflow and providers in the runner
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.