add basic system tests for OpenLineage#43643
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 27, 2024
Merged
Conversation
459da4f to
db41441
Compare
db41441 to
8b5b3c8
Compare
kacpermuda
approved these changes
Nov 15, 2024
Collaborator
kacpermuda
left a comment
There was a problem hiding this comment.
Looks good, leaving some nits - mostly naming or something similar.
providers/src/airflow/providers/openlineage/transport/variable.py
Outdated
Show resolved
Hide resolved
8b5b3c8 to
9ec2b3f
Compare
dstandish
reviewed
Nov 18, 2024
Lee-W
reviewed
Nov 19, 2024
providers/src/airflow/providers/openlineage/transport/variable.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/openlineage/transport/variable.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/openlineage/transport/variable.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/openlineage/transport/variable.py
Outdated
Show resolved
Hide resolved
9173b7a to
f9a59d7
Compare
Contributor
Author
|
@Lee-W fixed all the typing/style comments. |
f9a59d7 to
3a97b27
Compare
dstandish
reviewed
Nov 19, 2024
3a97b27 to
09ac15a
Compare
dstandish
reviewed
Nov 19, 2024
providers/src/airflow/providers/openlineage/transport/variable.py
Outdated
Show resolved
Hide resolved
09ac15a to
8d4f14b
Compare
8d4f14b to
f81bb0f
Compare
Lee-W
approved these changes
Nov 21, 2024
potiuk
approved these changes
Nov 21, 2024
d23957f to
6e5aa55
Compare
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
6e5aa55 to
ab743c1
Compare
eladkal
approved these changes
Nov 26, 2024
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added system tests to make sure our OpenLineage integration actually works as expected. Here's what's new:
The main idea is to have a reliable way to verify that we're sending the right OpenLineage events with the right format.
The test setup is pretty flexible - you can either define your expected events inline or keep them in JSON files, whatever works better for your use case.