Skip to content

Fix broken stat scheduler_loop_duration (#42886) #43544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Oct 31, 2024
Merged

Fix broken stat scheduler_loop_duration (#42886) #43544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions airflow/jobs/scheduler_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,16 +1105,18 @@ def _run_scheduler_loop(self) -> None:
)

for loop_count in itertools.count(start=1):
with Trace.start_span(span_name="scheduler_job_loop", component="SchedulerJobRunner") as span:
with Trace.start_span(
span_name="scheduler_job_loop", component="SchedulerJobRunner"
) as span, Stats.timer("scheduler.scheduler_loop_duration") as timer:
span.set_attribute("category", "scheduler")
span.set_attribute("loop_count", loop_count)
with Stats.timer("scheduler.scheduler_loop_duration") as timer:
if self.using_sqlite and self.processor_agent:
self.processor_agent.run_single_parsing_loop()
# For the sqlite case w/ 1 thread, wait until the processor
# is finished to avoid concurrent access to the DB.
self.log.debug("Waiting for processors to finish since we're using sqlite")
self.processor_agent.wait_until_finished()

if self.using_sqlite and self.processor_agent:
self.processor_agent.run_single_parsing_loop()
# For the sqlite case w/ 1 thread, wait until the processor
# is finished to avoid concurrent access to the DB.
self.log.debug("Waiting for processors to finish since we're using sqlite")
self.processor_agent.wait_until_finished()

with create_session() as session:
# This will schedule for as many executors as possible.
Expand Down