Skip to content

Fix alembic template & make pre-commit more resilient #43244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into from
Oct 22, 2024
Merged

Fix alembic template & make pre-commit more resilient #43244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow/migrations/script.py.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ from alembic import op
${imports if imports else ""}

# revision identifiers, used by Alembic.
revision = ${repr(up_revision)}
down_revision = ${repr(down_revision)}
revision = "${up_revision}"
down_revision = "${down_revision}"
branch_labels = ${repr(branch_labels)}
depends_on = ${repr(depends_on)}

Expand Down
2 changes: 1 addition & 1 deletion docs/apache-airflow/img/airflow_erd.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a874f49d63f37d46c47de8e473aa87b8877b0c5a9f670722017cfd0ea9aeec51
e1e32de9983ee02f268010485363ec222927c64e13be142761fc2b9f9cf33090
4 changes: 2 additions & 2 deletions scripts/in_container/run_migration_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ def ensure_filenames_are_sorted(revisions, app):


def correct_mismatching_revision_nums(revisions: Iterable[Script]):
revision_pattern = r'revision = "([a-fA-F0-9]+)"'
down_revision_pattern = r'down_revision = "([a-fA-F0-9]+)"'
revision_pattern = r'revision = ["\']([a-fA-F0-9]+)["\']'
down_revision_pattern = r'down_revision = ["\']([a-fA-F0-9]+)["\']'
revision_id_pattern = r"Revision ID: ([a-fA-F0-9]+)"
revises_id_pattern = r"Revises: ([a-fA-F0-9]+)"
for rev in revisions:
Expand Down