Handle AUTH_ROLE_PUBLIC in FAB auth manager#42280
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
We discussed in Airflow 3 Devcall that Provider changes and Core adjustments should not be mixed. Can you please separate the changes?
As it seems dependencies between provider and core are adjusted - are you sure the provider will stay compatible with Airflow 2.9?
Yes, similar to #42042, both changes (providers and core) are interrelated and it is impossible to split them. I am basically moving some features from core to providers so the provider will be compatible with Airflow 2.9. The only incompatibility is Airflow 3 with current or older version of FAB (because the feature is neither in Airflow and providers) but we decided (see comment) that Airflow 3 will require last version of Fab |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking nice. So that means I can safely remove the TODO comment in my other PR.
As I understand the backend is now checking automatically the AUTH_ROLE_PUBLIC if the user is None that's cleaner 👍
3faf77a to
5bf8f6b
Compare
5bf8f6b to
fa8ccb1
Compare
|
I cannot reproduce and understand why the compat tests are failing. I need to debug directly in the PR. Setting the PR in draft until I figure it out |
ea83a4d to
f556800
Compare
0f58a5a to
20a1656
Compare
Have you tried to run the compat tests local? Don't know how powerful your laptop is but for me this is a faster round trip. |
Yep I did, it complains because the amazon provider package is not installed. I could not figure it out why. But I actually found out the reason why the tests are failing by debugging by pushing things and waiting the CI for feedback :D |
20a1656 to
0ace7af
Compare
0ace7af to
fad0a59
Compare
|
CI is (finally) green! |
AUTH_ROLE_PUBLICis an option of FAB auth manager, it should not be handled in Airflow.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.