Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook#41916
Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook#41916potiuk merged 18 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
You will have to:
|
|
Whoops... Sorry. 🙏🏻 |
|
@Illumaria can you address the needed changes? I'm hoping to include this PR in the next release |
|
needs rebase and resolve conflicts |
|
@eladkal Sure, I’ll do it by the end of the weekend. |
|
Rebased after merging #43913 |
|
The above test failures are due to using |
|
Uhm... Is this a network issue on GitHub side? O_o |
Yeah.... Happens |
|
We (committers) can re-start that one failed job later after this PR completes all other checks. |
|
@potiuk Could you please re-run the failed test job? I don't think I have the rights. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Wooooohooo! (CC: @eladkal ) |
|
Thanks @Illumaria for the patience. It was not an easy one and it uncovered a number of edge-cases in our CI that we had to fix :) #protm |
|
Great work @Illumaria 👏🏻👏🏻 |
…noHook (apache#41916) --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
…noHook (apache#41916) --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Closes: #34828