Correct scheduled slots documentation and missing open telemetry span#41899
Merged
ferruzzi merged 2 commits intoapache:mainfrom Sep 3, 2024
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
mattogburke
commented
Aug 30, 2024
docs/apache-airflow/administration-and-deployment/logging-monitoring/metrics.rst
Outdated
Show resolved
Hide resolved
mattogburke
commented
Aug 30, 2024
docs/apache-airflow/administration-and-deployment/logging-monitoring/metrics.rst
Outdated
Show resolved
Hide resolved
e2c84b4 to
29766fb
Compare
Member
|
cc: @howardyoo @ferruzzi ? |
29766fb to
1ab269e
Compare
Contributor
The change looks good to me. Thanks for adding these missing attributes to the span :-) |
jedcunningham
approved these changes
Sep 3, 2024
ferruzzi
approved these changes
Sep 3, 2024
Contributor
ferruzzi
left a comment
There was a problem hiding this comment.
LGTM. The citations to the definitions in the code are a very nice touch, thanks for those.
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Member
|
Thanks @mattogburke! Congrats on your first commit 🎉 |
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 4, 2024
…apache#41899) * Correct documentation for pool.scheduled_slots metrics * Add missing pool.scheduled_slots telemetry span (cherry picked from commit 0a816c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new pool.scheduled_slots metrics added in #38899 has incorrect documentation, calling the field
pool.scheduled_tasks.Additionally this field isn't exposed in the open telemetry span data unlike all the other related
pool.{state}_slotsmetrics. I suspect this was missed in #40802^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.