Skip to content

Add Airflow 3 development readme#41457

Merged
eladkal merged 15 commits intoapache:mainfrom
eladkal:airflow3
Sep 11, 2024
Merged

Add Airflow 3 development readme#41457
eladkal merged 15 commits intoapache:mainfrom
eladkal:airflow3

Conversation

@eladkal
Copy link
Copy Markdown
Contributor

@eladkal eladkal commented Aug 14, 2024

Lets have a doc that list the protocols we accepted for development of Airflow 3

@eladkal eladkal mentioned this pull request Aug 14, 2024
Merged
uranusjr
uranusjr reviewed Aug 14, 2024
View reviewed changes
kaxil
kaxil approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One point of discussion is comments -- other than that lgtm

potiuk
potiuk reviewed Aug 14, 2024
View reviewed changes
@uranusjr
Copy link
Copy Markdown
Member

uranusjr commented Aug 14, 2024

Also, since I just opened a backport PR (#41469)

Is it expected to not have CI run? Should at least some test jobs run?

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Aug 14, 2024

Also, since I just opened a backport PR (#41469)

Is it expected to not have CI run? Should at least some test jobs run?

#41474 -> PRs workflows were only enabled for main. It might need some more fixes, but let's merge it to main and close/reopen your PR to see if it will succeed.

jscheffl
jscheffl approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation. Some clarifications and proposals in ordering, else from content I agree - therefore approve.

amoghrajesh
amoghrajesh reviewed Aug 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladkal this looks great, had a couple of comments and one qn.
BTW, should we also have a section that tells how to decide if a PR is supposed to go into AF3 or 2.10.x?

amoghrajesh
amoghrajesh approved these changes Aug 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

potiuk
potiuk reviewed Aug 18, 2024
View reviewed changes
@kaxil
Copy link
Copy Markdown
Member

kaxil commented Aug 19, 2024

Pre-commit (doctoc) is failing

+- [Milestones for PR](#milestones-for-pr)
+  - [Set 2.10.x milestone](#set-210x-milestone)
+  - [Set 2.11 milestone](#set-211-milestone)
+  - [Set 3 milestone](#set-3-milestone)

jscheffl
jscheffl reviewed Aug 19, 2024
View reviewed changes
jscheffl
jscheffl reviewed Aug 19, 2024
View reviewed changes
ephraimbuddy
ephraimbuddy reviewed Aug 19, 2024
View reviewed changes
@jscheffl
Copy link
Copy Markdown
Contributor

jscheffl commented Aug 19, 2024

Pre-commit (doctoc) is failing

+- [Milestones for PR](#milestones-for-pr)
+  - [Set 2.10.x milestone](#set-210x-milestone)
+  - [Set 2.11 milestone](#set-211-milestone)
+  - [Set 3 milestone](#set-3-milestone)

If we need to find more things that we need to take care as committer/PMS, we might really re-structure not from the role of contributor/committer but but it in the reversed order to describe per use case and have a checklist per PR what we should do? Will there be more things coming?

ephraimbuddy
ephraimbuddy reviewed Aug 19, 2024
View reviewed changes
ephraimbuddy
ephraimbuddy reviewed Aug 19, 2024
View reviewed changes
ephraimbuddy
ephraimbuddy reviewed Aug 19, 2024
View reviewed changes
ephraimbuddy
ephraimbuddy reviewed Aug 19, 2024
View reviewed changes
@eladkal
Copy link
Copy Markdown
Contributor Author

eladkal commented Aug 19, 2024

If we need to find more things that we need to take care as committer/PMS, we might really re-structure not from the role of contributor/committer but but it in the reversed order to describe per use case and have a checklist per PR what we should do? Will there be more things coming?

We can always change the doc structure (even now if you have a suggestion to make it more friendly)
I assume we will add/remove stuff as we move forward. For example after 2.11 the 2.10 branch related stuff won't be needed.

jscheffl
jscheffl reviewed Aug 21, 2024
View reviewed changes
hussein-awala
hussein-awala approved these changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

jscheffl
jscheffl reviewed Aug 22, 2024
View reviewed changes
potiuk
potiuk reviewed Aug 22, 2024
View reviewed changes
@potiuk potiuk mentioned this pull request Aug 22, 2024
Merged
shahar1
shahar1 reviewed Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - my comments are mostly regarding proofreading and style (apologies in advance for nitpicking).
General suggestion - being consistent when referring to a single or multiple PRs.

@eladkal
Copy link
Copy Markdown
Contributor Author

eladkal commented Sep 11, 2024

Merging. We can iterate/change the doc as needed

@eladkal eladkal merged commit 25cc8b2 into apache:main Sep 11, 2024
@eladkal eladkal deleted the airflow3 branch September 11, 2024 18:19
@eladkal eladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 11, 2024
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@eladkal @potiuk
@ephraimbuddy @joaopamaral
Add Airflow 3 development readme (apache#41457)
175b591 
* Add Airflow 3 development readme

* fix typo

* Update dev/README_AIRFLOW3_DEV.md

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

* restructure doc

* fix static checks

* updates

* fixes

* fix spell checks

* clarify cherry picking

* add milestones

* fix doc

* Update dev/README_AIRFLOW3_DEV.md

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

* add 2.11 mental model

* Update dev/README_AIRFLOW3_DEV.md

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

* fixes

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@uranusjr uranusjr uranusjr left review comments

@ephraimbuddy ephraimbuddy ephraimbuddy left review comments

@kaxil kaxil kaxil approved these changes

@shahar1 shahar1 shahar1 left review comments

@jscheffl jscheffl jscheffl approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@vikramkoka vikramkoka Awaiting requested review from vikramkoka

Assignees

No one assigned

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@eladkal @uranusjr @potiuk @kaxil @jscheffl @ephraimbuddy @hussein-awala @amoghrajesh @shahar1