Fix TriggerDagRunOperator Tests for Database Isolation Tests#41298
Merged
jscheffl merged 4 commits intoapache:mainfrom Aug 9, 2024
Merged
Conversation
Member
|
I think it makes sense to mark Trigger DAG Run as not working currently with internal API with TODO and comment that this is yet-another-thing that currently does not work with it. |
36dbd9f to
421943b
Compare
shahar1
reviewed
Aug 8, 2024
3bd8980 to
9b68ca6
Compare
vincbeck
approved these changes
Aug 9, 2024
potiuk
pushed a commit
that referenced
this pull request
Aug 11, 2024
* Attempt to fix TriggerDagRunOperator for Database Isolation Tests * Finalize making tests run for triggerdagrunoperator in db isolation mode * Adjust query count assert for adjustments to serialization * Review feedback (cherry picked from commit 6b810b8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #41067
I attempted to adjust the tests for TriggerDagRunOperator but going into details and after fixing some serialization and adding one API I realized that at least 3 more internal API calls would be needed (marked with TODO) - feels like for an internal API support for all corner cases (good cases are working!) the operator probably needs rather a full rewrite based on stable API. Currently too much specific logic is in there.
Therefore the non working options now are explicit markes as not working in Database Isolation Mode and tests are skipped