Skip to content

Fix indentation of scheduler_job_runner for standalone dag processor#40929

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-indentation-after-span-change
Jul 22, 2024
Merged

Fix indentation of scheduler_job_runner for standalone dag processor#40929
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-indentation-after-span-change

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Jul 22, 2024

The indentation in #40802 has changed heartbeating to not work in case of standalone date processing.

This PR fixes it back.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The indentation in apache#40802 has changed heartbeating to not work
in case of standalone date processing.

This PR fixes it back.
@potiuk potiuk requested review from XD-DENG, ashb and kaxil as code owners July 22, 2024 10:02
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jul 22, 2024
@potiuk potiuk requested a review from ferruzzi July 22, 2024 10:02
@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jul 22, 2024

cc @howardyoo

@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jul 22, 2024

(maybe you can also double check other identation changes @howardyoo in #40802 - just in case - I have not found any other, but this one shows that it could have happened. It's very easy to miss.

@howardyoo
Copy link
Copy Markdown
Contributor

(maybe you can also double check other identation changes @howardyoo in #40802 - just in case - I have not found any other, but this one shows that it could have happened. It's very easy to miss.

Ok, will check and let you know.

@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jul 22, 2024

Ok, will check and let you know.

Thank you :)

@potiuk potiuk requested a review from jscheffl July 22, 2024 12:03
@howardyoo
Copy link
Copy Markdown
Contributor

Ok, will check and let you know.

Thank you :)

Hi @potiuk , I've done the checks on the PR #40802 , and all looks good. I believe we can apply this PR to fix the indentation bug.

@potiuk potiuk merged commit 2a37728 into apache:main Jul 22, 2024
@potiuk potiuk deleted the fix-indentation-after-span-change branch July 22, 2024 15:38
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 22, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.10.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants