Skip to content

Tiny PR: Fix two typos in Weaviate provider code#40670

Merged
eladkal merged 1 commit intoapache:mainfrom
TJaniF:weaviate_provider_typo_fix
Jul 9, 2024
Merged

Tiny PR: Fix two typos in Weaviate provider code#40670
eladkal merged 1 commit intoapache:mainfrom
TJaniF:weaviate_provider_typo_fix

Conversation

@TJaniF
Copy link
Copy Markdown
Contributor

@TJaniF TJaniF commented Jul 9, 2024 •
edited
Loading

Fixing grcp -> grpc and get_collection_configuraiton to get_collection_configuration

both of these typos were introduced in #40194 which has not been part of a released version yet, so does not break anything :)

cc: @Lee-W

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jul 9, 2024

Actually that one - even if smalll - might want us to decide on cancelling waeviate from the current wave and creating rc2 (@Lee-W @eladkal )

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jul 9, 2024

See #40661 @TJaniF -> the provider's rc1 is being voted

@TJaniF
Copy link
Copy Markdown
Contributor Author

TJaniF commented Jul 9, 2024

See #40661 @TJaniF -> the provider's rc1 is being voted

Oh, I had not seen the vote email this morning, sorry!

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jul 9, 2024

Oh, I had not seen the vote email this morning, sorry!

Nothing to be sorry about :) ! There are so many things happening that I am somewhat surprise I am able to follow it :D

hussein-awala
hussein-awala approved these changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a major release in case someone provides the extra grcp_secure or uses the public method get_collection_configuraiton.

@hussein-awala
Copy link
Copy Markdown
Member

hussein-awala commented Jul 9, 2024

Actually that one - even if smalll - might want us to decide on cancelling waeviate from the current wave and creating rc2

If the change is not released yet, +1 to cancel the RC

@TJaniF
Copy link
Copy Markdown
Contributor Author

TJaniF commented Jul 9, 2024

Actually that one - even if smalll - might want us to decide on cancelling waeviate from the current wave and creating rc2

If the change is not released yet, +1 to cancel the RC

yes, the typos are not in any released version

@eladkal eladkal merged commit 728ee2e into apache:main Jul 9, 2024
@Lee-W
Copy link
Copy Markdown
Member

Lee-W commented Jul 9, 2024

Thank @TJaniF for the prompt fixing. Didn't notice it 🤦‍♂️

@eladkal eladkal mentioned this pull request Jul 12, 2024
Closed
27 tasks
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@TJaniF @romsharon98
fix two typos (apache#40670)
681b1ea
@Mohammed-Karim226 Mohammed-Karim226 mentioned this pull request Jan 27, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@eladkal eladkal eladkal approved these changes

Assignees

No one assigned

Labels

area:providers provider:weaviate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TJaniF @potiuk @hussein-awala @Lee-W @eladkal