Add jmespath as an explicit dependency#39350
Merged
jedcunningham merged 3 commits intoapache:mainfrom May 1, 2024
Merged
Conversation
The helm chart tests, AWS provider, and FAB provider all use `jmespath` directly, but we were only installing it as a dependency of a dependency (botocore is the most likely commonly used dep that requires it). Instead, since we use it ourselves, set it as a dep.
Taragolis
approved these changes
May 1, 2024
Taragolis
reviewed
May 1, 2024
vincbeck
approved these changes
May 1, 2024
eladkal
approved these changes
May 1, 2024
o-nikolas
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helm chart tests, AWS provider, and FAB provider all use
jmespathdirectly, but we were only installing it as a dependency of a dependency (botocore is the most likely commonly used dep that requires it). Instead, since we use it ourselves, set it as a dep.