Optimize DAG run scheduling based on dataset triggers and batching#37707
Closed
sunank200 wants to merge 1 commit intoapache:mainfrom
Closed
Optimize DAG run scheduling based on dataset triggers and batching#37707sunank200 wants to merge 1 commit intoapache:mainfrom
sunank200 wants to merge 1 commit intoapache:mainfrom
Conversation
2 tasks
d685fd5 to
479d77a
Compare
479d77a to
493a934
Compare
Collaborator
Author
|
Based on conversation with @dstandish - we can park this PR and work on more pressing issue first |
Collaborator
Author
|
Based on the conversation with @vatsrahul1001 this approach did not improve the performance hence not going ahead with this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces optimizations to the
dags_needing_dagrunsmethod in the DagModel class. The changes include the implementation of batch processing to efficiently handle large sets of DAG IDs. The motivation behind this change is to address the performance issues associated with processing a large number of DAGs, which can lead to significant memory usage and slow down the scheduler.Changes:
DatasetDagRunQueuerecords in batches, reducing memory usage and improving efficiency. This approach minimizes the overhead of loading and processing large numbers of DAGs simultaneously.Depends on the merge of PR #37016. and #37101
Dependency Checklist
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.