Skip to content

Add Yandex Query support from Yandex.Cloud#37458

Merged
Taragolis merged 34 commits intoapache:mainfrom
uzhastik:yq_support
Mar 20, 2024
Merged

Add Yandex Query support from Yandex.Cloud#37458
Taragolis merged 34 commits intoapache:mainfrom
uzhastik:yq_support

Conversation

@uzhastik
Copy link
Copy Markdown
Contributor


Add support for Yandex Query service in Yandex Cloud. Ability to run federative queries in Yandex Cloud.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Feb 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uzhastik uzhastik marked this pull request as ready for review February 15, 2024 17:11
Copy link
Copy Markdown
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Yandex cloud and their API, but is any chance that Yandex Query supported by yandexcloud

cc: @Piatachock @ImpressionableRaccoon

@Taragolis
Copy link
Copy Markdown
Contributor

@uzhastik
Copy link
Copy Markdown
Contributor Author

I'm not familiar with Yandex cloud and their API, but is any chance that Yandex Query supported by yandexcloud

cc: @Piatachock @ImpressionableRaccoon

yes, It's possible, but not now. we are trying different approach, described here: #37458 (comment)

@uzhastik
Copy link
Copy Markdown
Contributor Author

@Taragolis @potiuk @eladkal @rozza @ashb @jedcunningham hello, team! finally PR is green. please check it out! =))

Copy link
Copy Markdown
Contributor

@ImpressionableRaccoon ImpressionableRaccoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @eladkal ?

@uzhastik
Copy link
Copy Markdown
Contributor Author

@Taragolis @potiuk @eladkal @rozza @ashb @jedcunningham ping again =)

@Taragolis Taragolis dismissed eladkal’s stale review March 19, 2024 10:43

Resolved: No vendored parts into the PR

@Taragolis Taragolis merged commit 390bec1 into apache:main Mar 20, 2024
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Mar 20, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:yandex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants