Add deferrable implementation in HTTPSensor#36904
Merged
phanikumv merged 28 commits intoapache:mainfrom Jan 23, 2024
Merged
Conversation
273c92e to
b4d6b10
Compare
Lee-W
reviewed
Jan 20, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
…airflow into add_deferrable_to_httpsensor
Lee-W
reviewed
Jan 22, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
1 task
Lee-W
reviewed
Jan 22, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
…airflow into add_deferrable_to_httpsensor
Contributor
Author
updated docs with example |
Lee-W
approved these changes
Jan 23, 2024
Member
Lee-W
left a comment
There was a problem hiding this comment.
Left one minor suggestion but rest looks good to me
phanikumv
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address deferrable logic for HTTPSensor
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.