Switch to mongo_conn_id argument into the MongoHook constructor#36896
Merged
eladkal merged 1 commit intoapache:mainfrom Jan 19, 2024
Merged
Switch to mongo_conn_id argument into the MongoHook constructor#36896eladkal merged 1 commit intoapache:mainfrom
mongo_conn_id argument into the MongoHook constructor#36896eladkal merged 1 commit intoapache:mainfrom
Conversation
eladkal
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of: #28946
Docstring in MongoHook mentioned about
mongo_conn_id, but this parameter is not take any affect.conn_idis also too generic. So let's switch to themongo_conn_idinstead and make it consistent to other mongo Operators/Sensors which are usemongo_conn_idinternally.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.