Fix stacklevel in warnings.warn into the providers#36831
Merged
Taragolis merged 1 commit intoapache:mainfrom Jan 18, 2024
Merged
Fix stacklevel in warnings.warn into the providers#36831Taragolis merged 1 commit intoapache:mainfrom
Taragolis merged 1 commit intoapache:mainfrom
Conversation
Taragolis
commented
Jan 17, 2024
9f3cb1f to
43915a9
Compare
potiuk
approved these changes
Jan 17, 2024
Member
potiuk
left a comment
There was a problem hiding this comment.
Nice. I was wondering if there is a way to somehow automate it - or maybe just flag and require to make a deliberate decision when you reais exception in the provider?
Contributor
Author
|
Missing stacklevel=1 in most cases it useless level, because it point to exact place where it raised rather than where it called. We could add B028 to ruff config as soon as we resolve this PR, #36834 and make changes in core |
josh-fell
approved these changes
Jan 17, 2024
dirrao
approved these changes
Jan 18, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During check warnings which generated in our CI I've found that time to time we use
stacklevel=1or even do not define it at all. This make it harder to find where actual call is happen.There is rule
B028exists into therufffor validate missingstacklevelinto the code, however nothing it could do with explicitstacklevel=1There is additional changes exists in warnings, which I point into the separate discussions
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.