Update the redshift hostname check to avoid possible bugs#36703
Merged
hussein-awala merged 1 commit intoapache:mainfrom Jan 9, 2024
Merged
Update the redshift hostname check to avoid possible bugs#36703hussein-awala merged 1 commit intoapache:mainfrom
hussein-awala merged 1 commit intoapache:mainfrom
Conversation
vincbeck
approved these changes
Jan 9, 2024
o-nikolas
approved these changes
Jan 9, 2024
Contributor
|
Re-ran the failed build step, it is unrelated to this change. Hopefully it will pass the second time around! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
"amazonaws.com" in hostnamewithhostname.endswith("amazonaws.com")because we expect that this substring comes at the end of the hostname and not anywhere in the hostname string as explained in the log message below it.