Make sure multiple_outputs is inferred correctly even when using TypedDict#36652
Merged
jscheffl merged 3 commits intoapache:mainfrom Jan 10, 2024
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
jscheffl
reviewed
Jan 7, 2024
Contributor
|
Now just a small "glitch" in imports due to static checks... https://github.com/apache/airflow/actions/runs/7444185558/job/20275885423?pr=36652 |
josh-fell
reviewed
Jan 9, 2024
Contributor
josh-fell
left a comment
There was a problem hiding this comment.
Probably worth adding a note about this to the doc you referenced too.
ec4f611 to
70a0a94
Compare
jscheffl
approved these changes
Jan 10, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
68 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation here, the
multiple_outputsparameter should automatically set to true if adictis being used as the function return type.The current condition in
_infer_multiple_outputs()does not consider aTypedDictas adictfor that matter, as well as any other subclass ofdict.This PR uses
issubclass()to make sure anytyping.Mappingsubclass will makemultiple_outputs=True^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.