Add openlineage support for CopyFromExternalStageToSnowflakeOperator#36535
Merged
mobuchowski merged 1 commit intoapache:mainfrom Jan 8, 2024
Merged
Conversation
Collaborator
Author
|
Also adding @mobuchowski |
f36a85d to
6ca2185
Compare
6ca2185 to
da1bafb
Compare
mobuchowski
approved these changes
Jan 8, 2024
Contributor
mobuchowski
left a comment
There was a problem hiding this comment.
LGTM, might want to add comment to one nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Openlineage in CopyFromExternalStageToSnowflakeOperator.
I had a few different ideas (DESCRIBE STAGE, DESCRIBE TABLE etc.) about how to get some additional information about the files that are loaded and snowflake table itself, but this relying on the output of the query is the only one i came up with that does not require any additional Snowflake permissions apart from what You need to perform COPY INTO operation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.