Fix AirflowSkipException message raised by KubernetesPodOperator#36355
Merged
Conversation
dolfinus
force-pushed
the
k8s-exit-code
branch
from
December 21, 2023 18:11
601ca4c to
473d11a
Compare
dolfinus
force-pushed
the
k8s-exit-code
branch
from
December 21, 2023 18:13
473d11a to
4a2333a
Compare
dolfinus
force-pushed
the
k8s-exit-code
branch
3 times, most recently
from
December 21, 2023 19:57
c732169 to
c53891d
Compare
dolfinus
marked this pull request as ready for review
December 21, 2023 20:33
dolfinus
requested review from
hussein-awala and
jedcunningham
as code owners
December 21, 2023 20:33
hussein-awala
requested changes
Dec 21, 2023
dolfinus
force-pushed
the
k8s-exit-code
branch
from
December 21, 2023 21:05
c53891d to
f0bf46b
Compare
hussein-awala
approved these changes
Dec 21, 2023
dolfinus
force-pushed
the
k8s-exit-code
branch
3 times, most recently
from
December 21, 2023 21:37
65f2b5c to
27d8fee
Compare
This was referenced Dec 21, 2023
dolfinus
marked this pull request as draft
December 21, 2023 21:53
dolfinus
force-pushed
the
k8s-exit-code
branch
from
December 21, 2023 21:55
27d8fee to
f629cc0
Compare
dolfinus
marked this pull request as ready for review
December 21, 2023 22:14
hussein-awala
approved these changes
Dec 21, 2023
hussein-awala
left a comment
Member
There was a problem hiding this comment.
I checked the recent changes, and they look good. Waiting for a second approval before merging.
dolfinus
force-pushed
the
k8s-exit-code
branch
from
December 23, 2023 09:10
f629cc0 to
018124a
Compare
Contributor
|
Looks good! |
eladkal
approved these changes
Dec 24, 2023
potiuk
approved these changes
Dec 24, 2023
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KubernetesPodOperator.skip_on_exit_codeis always a container (likelist[int]), it cannot beNone.AirflowSkipExceptionshould contain exact exit code instead of container value.KubernetesPodOperator(skip_no_exit_code=0)to skip successfully finished pods. Previously it was the same asKubernetesPodOperator(skip_no_exit_code=[])^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.