Fix CloudRunExecuteJobOperator in deferrable mode#36012
Merged
Conversation
… status in deferrable mode
potiuk
approved these changes
Dec 1, 2023
50 tasks
19 tasks
84 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudRunExecuteJobOperator is not able to retrieve the Cloud Run job status in deferrable mode.
This behavior is observed only when deferrable is set to True. With False, it is giving the correct status of the task and even retrying upon failure.
The error occurred because Operation object that is returned in trigger after calling get_operation() method contains both error and response fields. That is why the first check if response exists in Operation object returns True every time even if the error occurred.
The actual content of those fields could be retrieved by calling SerializeToString().
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.