Enable overscroll on the DAG Grid page#35717
Merged
bbovenzi merged 2 commits intoapache:mainfrom Nov 28, 2023
Merged
Conversation
Member
hussein-awala
left a comment
There was a problem hiding this comment.
Could you add screenshots to description for before and after this change?
Contributor
Author
done |
bbovenzi
approved these changes
Nov 28, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit d37b91c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable overscroll on the DAG Grid page so that when a user scrolls down the Grid it is possible to scroll to the very bottom.
closes: #33699
Before:
scrolling further down has no effect, the tasks in the bottom of the grid are not visible
After:
scrolling further down scrolls the whole page to the bottom, tasks in the bottom of the grid are visible
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.