KubernetesPodTrigger: add exception stack trace in TriggerEvent#35716
Merged
Conversation
functicons
requested review from
hussein-awala and
jedcunningham
as code owners
November 18, 2023 00:55
eladkal
reviewed
Nov 26, 2023
Contributor
Author
|
@jedcunningham and @hussein-awala, could you review this PR? Thank you in advance! |
Contributor
Author
|
Friendly ping! Thanks! |
Contributor
|
@hussein-awala @jedcunningham can chime in, please? |
potiuk
approved these changes
Dec 16, 2023
84 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#34644
In deferrable mode, the current logs are not sufficient to debug issues happened in the trigger or hook, so adding stack trace and log the event in the operator callback method.