Skip to content

Added Datascan Profiling#35696

Merged
potiuk merged 20 commits into
apache:mainfrom
shourya116:profile
Dec 12, 2023
Merged

Added Datascan Profiling#35696
potiuk merged 20 commits into
apache:mainfrom
shourya116:profile

Conversation

@shourya116

Copy link
Copy Markdown
Contributor

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Nov 17, 2023
@shourya116 shourya116 changed the title Added tests for Datascan Data Profile Source Added Datascan Profiling Nov 17, 2023
@potiuk

potiuk commented Nov 17, 2023

Copy link
Copy Markdown
Member

Need to get green first. I recommend installingpre-commit as well.

@potiuk
potiuk force-pushed the profile branch 2 times, most recently from 9494a22 to b310400 Compare November 30, 2023 13:31
@potiuk

potiuk commented Nov 30, 2023

Copy link
Copy Markdown
Member

Yes. the problem in this PR is that you have not run it through pre-commit - which means dependencies have not been regenerated and the image fails to be built, so in order to do anything about it you need to install and run pre-commit with your change first - see the CONTRIBUTNG docs and look for pre-commit if in doubt

@potiuk

potiuk commented Dec 4, 2023

Copy link
Copy Markdown
Member

cc: @VladaZakharova and team ?

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if @VladaZakharova and team have no comments.

@potiuk
potiuk merged commit 47a9c8a into apache:main Dec 12, 2023
@boring-cyborg

boring-cyborg Bot commented Dec 12, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants