Make raw HTML descriptions configurable#35460
Merged
jscheffl merged 18 commits intoapache:mainfrom Nov 12, 2023
Merged
Conversation
potiuk
reviewed
Nov 5, 2023
potiuk
reviewed
Nov 5, 2023
potiuk
reviewed
Nov 5, 2023
potiuk
reviewed
Nov 5, 2023
uranusjr
reviewed
Nov 6, 2023
uranusjr
reviewed
Nov 6, 2023
…-description-in-params-configurable
jedcunningham
approved these changes
Nov 9, 2023
…-description-in-params-configurable
Member
|
Looks like all checks passed :) |
Member
|
I think the only thing we need is |
Contributor
Author
@potiuk how about the one already in? --> https://github.com/apache/airflow/pull/35460/files#diff-1fa4ad17cb7d1ce8e7e5c724a04fceaac361d7cc44f4c27143359083cb4bb700 |
Member
Good enough :) |
|
mentioned by CVE-2023-47265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With AIP-50 we introduced trigger forms and such trigger forms allow to provide raw HTML by DAG authors as descriptions.
During Airflow Summit there were some concerns discussed whether a DAG author would be able to inject dangerous JavaScript into the HTML and how Airflow handles this.
This PR changes the raw HTML support in Airflow in the way:
allow_html_in_dag_docsis added, which defaults to Falsecustom_html_formin trigger DAG UI is marked as deprecated for a future / better solution