Add support for ZoneInfo and generic UTC#34683
Conversation
Certain providers rely on other datetime implementations and fail to serialize.
Be forward and backward compatible
|
I'd like time to pull these changes and see if it fixes the issue that the system test caught rather than just looking at the code and guessing, but I might not get to that until Tuesday. If anyone gets time to do that, I'd greatly appreciate the help and confirmation. Test request: Pull these changes down and successfully execute a DAG which passes the timestamp from |
| i = DateTime(2022, 7, 10, tzinfo=tzutc()) | ||
| s = serialize(i) | ||
| d = deserialize(s) |
There was a problem hiding this comment.
@ferruzzi, IMO your question about encode/decode datetimes from boto3 covered by this test case
There was a problem hiding this comment.
I think you are likely right, ad the code does look good "on paper", I was just hoping to make time to actually try it in a live environment to verify. I won't block the merge if you are confident. 👍
Tuesday is fine, we're not in a hurry. Rather have you confirm it, although the tests should now cover it too. |
ferruzzi
left a comment
There was a problem hiding this comment.
I thought I could checkout this PR and run it, but if that's possible, I can't seem to figure it out. The code does look good, I was just hoping to verify it in action. Going to approve it as-is.
|
Oops, seeing that tests are failing due to import errors. Looking into it. |
* Add support for ZoneInfo and generic UTC Certain providers rely on other datetime implementations and fail to serialize. (cherry picked from commit 7707f4a)
Certain providers rely on other datetime implementations than pendulum and fail to serialize.
See also: #34673
@Taragolis @ferruzzi
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.