Fix bad "code cleanup" in celery executor#34192
Merged
Merged
Conversation
Fixes error introduced in code cleanup PR apache#33987
hussein-awala
approved these changes
Sep 7, 2023
hussein-awala
left a comment
Member
There was a problem hiding this comment.
I'm wondering how the CI didn't block my PR 🤔
Contributor
Author
|
That's the risk with this kind of code cleanup PR... of which there have been a lot lately! Not saying we shouldn't do them just... it's always a risk |
vincbeck
approved these changes
Sep 7, 2023
Lee-W
approved these changes
Sep 8, 2023
eladkal
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error introduced in code cleanup PR #33987