Skip to content

Used cached property for hook in SparkKubernetesOperator #34130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josh-fell merged 1 commit into from
Sep 6, 2023
Merged

Used cached property for hook in SparkKubernetesOperator #34130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from __future__ import annotations

import datetime
from functools import cached_property
from typing import TYPE_CHECKING, Sequence

from kubernetes.client import ApiException
Expand Down Expand Up @@ -81,7 +82,9 @@ def __init__(
self.config_file = config_file
self.watch = watch

self.hook = KubernetesHook(
@cached_property
def hook(self) -> KubernetesHook:
return KubernetesHook(
conn_id=self.kubernetes_conn_id,
in_cluster=self.in_cluster,
config_file=self.config_file,
Expand Down
19 changes: 17 additions & 2 deletions tests/providers/cncf/kubernetes/operators/test_spark_kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,31 @@

@patch("airflow.providers.cncf.kubernetes.operators.spark_kubernetes.KubernetesHook")
def test_spark_kubernetes_operator(mock_kubernetes_hook):
SparkKubernetesOperator(
operator = SparkKubernetesOperator(
task_id="task_id",
application_file="application_file",
kubernetes_conn_id="kubernetes_conn_id",
in_cluster=True,
cluster_context="cluster_context",
config_file="config_file",
)
mock_kubernetes_hook.assert_not_called() # constructor shouldn't call the hook

mock_kubernetes_hook.assert_called_once_with(
assert "hook" not in operator.__dict__ # Cached property has not been accessed as part of construction.


@patch("airflow.providers.cncf.kubernetes.operators.spark_kubernetes.KubernetesHook")
def test_spark_kubernetes_operator_hook(mock_kubernetes_hook):
operator = SparkKubernetesOperator(
task_id="task_id",
application_file="application_file",
kubernetes_conn_id="kubernetes_conn_id",
in_cluster=True,
cluster_context="cluster_context",
config_file="config_file",
)
operator.hook
mock_kubernetes_hook.assert_called_with(
conn_id="kubernetes_conn_id",
in_cluster=True,
cluster_context="cluster_context",
Expand Down