Make sure that only valid elasticsearch keys are passed to handler#34119
Merged
Conversation
2 tasks
potiuk
force-pushed
the
fix-elasticsearch-providers-pre-2-7-1
branch
from
September 5, 2023 20:02
2ec9645 to
2ae43b0
Compare
Taragolis
reviewed
Sep 5, 2023
potiuk
force-pushed
the
fix-elasticsearch-providers-pre-2-7-1
branch
5 times, most recently
from
September 5, 2023 20:59
6c37f5a to
3e32fea
Compare
Taragolis
reviewed
Sep 5, 2023
pankajkoti
approved these changes
Sep 6, 2023
pankajkoti
left a comment
Member
There was a problem hiding this comment.
Tested the PR on the ES remote logging with the installed stack on my end. Works fine.
potiuk
force-pushed
the
fix-elasticsearch-providers-pre-2-7-1
branch
2 times, most recently
from
September 6, 2023 21:51
48773c0 to
2183283
Compare
Member
Author
|
All things addressed @Taragolis I think. Good eye for details! |
The elasticsearch handler got all configuraiton parameters from the "elasticsearch_config" section but it means that in airflow versions pre 2.7 it could get old config keys which renders the new provider unusable. This PR filters out configuration parameter to only pass valid parameters for the new handler. Fixes: apache#34099
potiuk
force-pushed
the
fix-elasticsearch-providers-pre-2-7-1
branch
from
September 6, 2023 21:56
2183283 to
23d1da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The elasticsearch handler got all configuraiton parameters from the "elasticsearch_config" section but it means that in airflow versions pre 2.7 it could get old config keys which renders the new provider unusable.
This PR filters out configuration parameter to only pass valid parameters for the new handler.
Fixes: #34099
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.