Make Amazon Chime connection lazy loaded and consistent with docs#34000
Merged
vincbeck merged 1 commit intoSep 1, 2023
Merged
Conversation
Taragolis
force-pushed
the
chime-connection-ui-docs-consistent
branch
from
September 1, 2023 11:20
780cba3 to
8060675
Compare
vincbeck
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that
ChimeWebhookHookdo not access to Airflow Connection in constructor. It should not affect (improve) anything in community provider. However might prevent unwanted connections in the user specific OperatorsDefine same name for connection fields which are mentioned into the documentation
And rename connection name, it should not affect users pipelines, because this only uses in two places Connection type dropdown selector and in
airflow providers hookwhich are intend to show available connections^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.