openlineage, dbt: add OpenLineage support for DBT Cloud#33959
Merged
Conversation
mobuchowski
requested changes
Sep 1, 2023
mobuchowski
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but I have few issues mostly around documenting some of the changes.
Contributor
Author
There was a problem hiding this comment.
The primary motivation is to obtain an instance of the OpenLineageClient. It's advisable to create just one instance of the OpenLineageListener, as there is no requirement for additional instances. This single-instance approach convinced me to acquire the listener instead of the client. Additionally, this approach offers more flexibility in accessing other attributes of the OpenLineage listener if the need arises.
JDarDagran
force-pushed
the
aip-53-dbt-cloud
branch
5 times, most recently
from
September 5, 2023 08:51
04b7257 to
420f3d8
Compare
Contributor
Author
|
GitHub actions are still degraded. I'll rebase once the situation seems to stabilize. |
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
potiuk
force-pushed
the
aip-53-dbt-cloud
branch
from
September 5, 2023 14:40
420f3d8 to
585027d
Compare
Member
|
rebased. seems GA are back |
mobuchowski
approved these changes
Sep 7, 2023
This was referenced Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds OpenLineage support for DBT Cloud operator and sensor.